fix(tests): wait for listener readiness in TestWorkerWithInactiveWatcher - #2528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`TestWorkerWithInactiveWatcher` calls `tester.InitServer` and immediately asserts against the app endpoint. `caddytest`'s own readiness check only polls the admin API, not the app-facing listener, so under load a request can land in the gap and get an EOF (seen in CI: https://github.com/php/frankenphp/actions/runs/29648714936/job/88091254601).
The existing `initServer` helper in this package works around a similar race, but it polls via a real HTTP GET, which isn't usable here since this test asserts an exact worker request counter starting at 1.
Adds `waitForListener`, which polls a raw TCP dial/close (no HTTP, no counter impact) until the listener accepts connections, before the counted requests.
Verified with repeated full-suite runs locally.